Copilot commented on code in PR #41128:
URL: https://github.com/apache/superset/pull/41128#discussion_r3424028042
##########
superset-frontend/src/SqlLab/components/TemplateParamsEditor/index.tsx:
##########
@@ -30,10 +30,10 @@ import {
import { EditorHost } from 'src/core/editors';
import useQueryEditor from 'src/SqlLab/hooks/useQueryEditor';
-const StyledEditorHost = styled(EditorHost)`
- &.ace_editor {
- border: 1px solid ${({ theme }) => theme.colorBorder};
- }
+const EditorOutline = styled.div`
+ border: 1px solid ${({ theme }) => theme.colorBorder};
+ border-radius: ${({ theme }) => theme.borderRadius}px;
+ overflow: hidden;
`;
Review Comment:
`overflow: hidden` on the editor wrapper will clip Ace popovers/tooltips
(e.g. `.ace_tooltip`, autocomplete menus) when they extend beyond the editor
bounds. This can make editor diagnostics or UI affordances unreadable. Consider
removing the overflow clipping (or alternatively, apply `border-radius`
directly on the `.ace_editor` element instead of clipping at the container
level).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
