sha174n commented on PR #41120: URL: https://github.com/apache/superset/pull/41120#issuecomment-4725039311
@bito-code-review Added dedicated unit tests for `_resolve_query_schema` (probe construction plus blank-schema handling) in 4617bdc3c1. On the schema-resolution call in `sql_lab.py`: the exception it can raise is the intended per-query engine gate and is already handled by the SQL Lab error path, so it is deliberately propagated rather than swallowed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
