rusackas commented on code in PR #41132:
URL: https://github.com/apache/superset/pull/41132#discussion_r3463175712
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -43,14 +42,11 @@ function BigNumberVis({
kickerFontSize = PROPORTION.KICKER,
metricNameFontSize = PROPORTION.METRIC_NAME,
showMetricName = true,
- mainColor = BRAND_COLOR,
showTimestamp = false,
showTrendLine = false,
- startYAxisAtZero = true,
subheader = '',
subheaderFontSize = PROPORTION.SUBHEADER,
subtitleFontSize = PROPORTION.SUBHEADER,
- timeRangeFixed = false,
...props
}: BigNumberVizProps) {
Review Comment:
Good catch on the dead read in the component. The wrinkle is
`transformProps` is typed `: BigNumberVizProps` and still sets `mainColor` and
`startYAxisAtZero` in its return, so dropping those from the type means also
pulling them out of the transform... which feels like more than this lint-rule
PR should be doing. `timeRangeFixed` is the only one not in the return. Want me
to trim just `timeRangeFixed` here and leave the other two for a focused
follow-up, or pull the whole thread in?
##########
superset-frontend/src/dashboard/components/Dashboard.tsx:
##########
@@ -114,12 +114,8 @@ function Dashboard({
slices,
activeFilters,
chartConfiguration,
- datasources,
ownDataCharts,
layout,
- impressionId,
- timeout = 60,
- userId = '',
children,
}: DashboardProps): JSX.Element {
Review Comment:
Same situation as the BigNumber one... these four are still mapped in via
`mapStateToProps` in `containers/Dashboard.ts` (`datasources`, `impressionId`,
`timeout`, `userId`), so trimming them from `DashboardProps` means also
stripping them out of the connect, which `connect()` will then flag. Agreed
`datasources` as a no-op is the confusing one. I am inclined to do that
cleanup, but as its own PR rather than smuggle it into the lint flip... does
that work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
