dpgaspar commented on code in PR #39469: URL: https://github.com/apache/superset/pull/39469#discussion_r3428203780
########## superset/models/auth_audit_log.py: ########## @@ -0,0 +1,65 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Authentication audit log entries for AUTH_DB flows.""" + +from __future__ import annotations + +import uuid +from datetime import datetime, timezone + +from flask_appbuilder import Model +from sqlalchemy import Column, DateTime, ForeignKey, Integer, String, Text +from sqlalchemy.orm import relationship +from sqlalchemy.types import JSON +from sqlalchemy_utils import UUIDType + +from superset import security_manager + + +def _utc_now() -> datetime: + return datetime.now(timezone.utc) + + +class AuthAuditLog(Model): Review Comment: Would prefer to just use the existing `Log` table. Already has an adapter to send these to other storage types and pruning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
