bito-code-review[bot] commented on code in PR #39469: URL: https://github.com/apache/superset/pull/39469#discussion_r3433251502
########## superset/migrations/versions/2026-04-19_14-30_b7e4f2a891c3_add_auth_audit_log_table.py: ########## @@ -0,0 +1,65 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""add auth_audit_log table + +Revision ID: b7e4f2a891c3 +Revises: 78a40c08b4be Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Alembic migration chain broken</b></div> <div id="fix"> This migration (dated 2026-04-19) cannot correctly depend on migration `78a40c08b4be` (dated 2026-06-03, ~6 weeks later). Alembic migration chains must maintain chronological ordering — a migration cannot depend on a future migration. This will cause Alembic to fail when attempting to apply migrations in sequence. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/migrations/versions/2026-04-19_14-30_b7e4f2a891c3_add_auth_audit_log_table.py +++ superset/migrations/versions/2026-04-19_14-30_b7e4f2a891c3_add_auth_audit_log_table.py @@ -17,7 +17,7 @@ """add auth_audit_log table Revision ID: b7e4f2a891c3 -Revises: 78a40c08b4be +Revises: ce6bd21901ab Create Date: 2026-04-19 14:30:00.000000 """ @@ -31,7 +31,7 @@ # revision identifiers, used by Alembic. revision = "b7e4f2a891c3" -down_revision = "78a40c08b4be" +down_revision = "ce6bd21901ab" ``` </div> </details> </div> <small><i>Code Review Run #859504</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
