shantanukhond commented on PR #39469: URL: https://github.com/apache/superset/pull/39469#issuecomment-4752212077
> The session-before-commit fix looks good, thanks! Just a couple things still holding up the PR. @dpgaspar asked about reusing the existing `Log` table rather than a new `auth_audit_log` (plus its migration). Also, this is still the XXL bundle you and @EnxDev agreed to narrow down to Pillar 1, with the audit-log infra and admin reset riding along. Can we land just the `/me/password` change first and split the rest out? This also needs a rebase... happy to try tackling that part if it helps. Done! Changed from `auth_audit_log` to existing `log`. And I am just focusing on Pillar 1 Only. I was just getting overwhelmed by all the comments by bots 😕. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
