rusackas commented on PR #39118: URL: https://github.com/apache/superset/pull/39118#issuecomment-4747889567
@Pawansingh3889 the rename itself is clean and lines dashboards up with `hydrateExplore.ts` and `usePermissions`, nicely. But #24290 only asked for the rename, and the `can_export_data` switch in `hydrate.ts` is why this has the breaking-change label. With `GranularExportControls` on, anyone who has `can_csv` but not `can_export_data` silently loses the download button, as @sadpandajoe flagged. Can we either split the behavior change out into its own PR, or keep a `can_csv` fallback so nobody loses access silently? Also worth noting @jaymasiwal's review is still officially requesting changes even after the LGTM comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
