Pawansingh3889 commented on PR #39118: URL: https://github.com/apache/superset/pull/39118#issuecomment-4750322462
Thanks @rusackas — fair point. #24290 only asked for the rename, so I've reverted the `can_export_data` switch out of `hydrate.ts`. This PR is now a pure rename (`superset_can_csv` → `superset_can_download`, still reading `can_csv`), so there's no permission behaviour change and nobody loses access silently. The `risk:breaking-change` label should be safe to drop now. I'll open a separate PR for the `GranularExportControls` behaviour with a `can_csv` fallback so we can discuss the permission change on its own. @jaymasiwal — re-requesting your review, since the behaviour change that prompted the request is now gone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
