Ujjwaljain16 commented on PR #37978: URL: https://github.com/apache/superset/pull/37978#issuecomment-4754373249
Thanks for the review @EnxDev u were right to question the original approach i dug deeper and found that the `preventDefault()` theory was incorrect and switching to `stopPropagation()` in `ModalTrigger.open()` actually introduced a regression after tracing the event flow more carefully the issue turned out to be keyboard events bubbling through the React tree from the modal back into the hidden menu, where `rc-menu`'s accessibility handlers call `preventDefault()` for navigation keys that also explains why the input-level workaround reported above worked have reworked the patch accordingly appreciate u pushing on the root cause here the additional investigation led to a much cleaner fix happy to adjust further if needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
