rusackas commented on PR #37978: URL: https://github.com/apache/superset/pull/37978#issuecomment-4755032960
Also, FWIW, the PR body is out of date. It still describes replacing preventDefault() with stopPropagation() in open(), while the current patch intentionally preserves preventDefault() and stops keydown propagation around the modal body. Worth updating before merge so future readers (and my new PR history scraping mechanisms) don’t chase the old implementation/theory. ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
