codeant-ai-for-open-source[bot] commented on code in PR #37978:
URL: https://github.com/apache/superset/pull/37978#discussion_r3454825054
##########
superset-frontend/packages/superset-ui-core/src/components/ModalTrigger/ModalTrigger.test.tsx:
##########
@@ -17,6 +17,7 @@
* under the License.
*/
import { render, screen, userEvent } from '@superset-ui/core/spec';
+import { Menu } from 'antd';
Review Comment:
**Suggestion:** Replace the direct `antd` import with the `Menu` component
from `@superset-ui/core` (or the package's approved `Menu` wrapper) so the test
follows the frontend import policy. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a frontend TSX test file, and it imports `Menu` directly from `antd`.
The provided rule explicitly forbids direct Ant Design imports in frontend
UI code
in favor of `@superset-ui/core` or approved wrappers, so this is a real
violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=581ca775534740be9ec6905d4c6b145a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=581ca775534740be9ec6905d4c6b145a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/components/ModalTrigger/ModalTrigger.test.tsx
**Line:** 20:20
**Comment:**
*Custom Rule: Replace the direct `antd` import with the `Menu`
component from `@superset-ui/core` (or the package's approved `Menu` wrapper)
so the test follows the frontend import policy.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37978&comment_hash=3a1e86d74da1d8b721fff292c7b75e9b95836689813ff72160b9ea8471e4e74e&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37978&comment_hash=3a1e86d74da1d8b721fff292c7b75e9b95836689813ff72160b9ea8471e4e74e&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
