codeant-ai-for-open-source[bot] commented on code in PR #41199:
URL: https://github.com/apache/superset/pull/41199#discussion_r3453015510
##########
superset-frontend/src/SqlLab/components/EditorWrapper/useKeywords.ts:
##########
@@ -197,7 +205,7 @@ export function useKeywords(
() =>
allCachedTables.map(({ value, label, schema: tableSchema }) => ({
name: label,
- value,
+ value: quoteIdentifier(value),
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag quoted table completion values in the Ace editor path when
`toAceKeyword` strips `completer`; in that flow `insertMatch` does not run, so
autocomplete insertion does not call `addTable` or store quoted names in table
state/API calls.
**Applied to:**
- `superset-frontend/src/SqlLab/components/AceEditorProvider.tsx`
- `superset-frontend/src/SqlLab/components/EditorWrapper/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
