jesperct commented on code in PR #41199:
URL: https://github.com/apache/superset/pull/41199#discussion_r3453010660
##########
superset-frontend/src/SqlLab/components/EditorWrapper/useKeywords.ts:
##########
@@ -197,7 +205,7 @@ export function useKeywords(
() =>
allCachedTables.map(({ value, label, schema: tableSchema }) => ({
name: label,
- value,
+ value: quoteIdentifier(value),
Review Comment:
This does not apply on the Ace editor path. `toAceKeyword` in
`AceEditorProvider.tsx` copies only `name/value/score/meta/docText/docHTML` and
drops `completer`, so `insertMatch` never runs and `addTable` is not called on
selection. Ace inserts `value` directly, which is why the fix quotes `value`.
No quoted name reaches table state or the metadata API through this path. The
`addTable` side effect on select is already inactive for the same reason,
independent of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
