rusackas commented on PR #41199: URL: https://github.com/apache/superset/pull/41199#issuecomment-4814436726
@bito-code-review I traced this before merging and I think it's a false positive in our case. The quoted value only reaches addTable via the completer's insertMatch, but the stock SQL Lab editor renders through EditorHost -> AceEditorProvider, whose toAceKeyword mapper drops the completer field entirely, so insertMatch never runs and addTable never sees the quoted string. The quoting only affects the text Ace inserts into the buffer, which is exactly the intended fix. Happy to reopen if there's an editor path I'm missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
