bito-code-review[bot] commented on code in PR #40129:
URL: https://github.com/apache/superset/pull/40129#discussion_r3455360899
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -3060,6 +3060,9 @@ msgstr "Изменения диаграммы"
msgid "Chart could not be created."
msgstr "Не удалось создать диаграмму"
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Russian translation</b></div>
<div id="fix">
The new translation entry `msgid "Chart could not be restored."` has an
empty `msgstr ""` with no `#, fuzzy` flag, meaning it will display the raw
English text to Russian-speaking users when a chart restore fails. This
degrades user experience for this locale.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- a/superset/translations/ru/LC_MESSAGES/messages.po
+++ b/superset/translations/ru/LC_MESSAGES/messages.po
@@ -3061,6 +3061,7 @@ msgstr "Не удалось создать диаграмму"
msgid "Chart could not be restored."
-msgstr ""
+msgstr "Не удалось восстановить диаграмму."
msgid "Chart could not be updated."
msgstr "Не удалось обновить диаграмму."
```
</div>
</details>
</div>
<small><i>Code Review Run #697b9f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/it/LC_MESSAGES/messages.po:
##########
@@ -2999,6 +2999,9 @@ msgstr "Ultima Modifica"
msgid "Chart could not be created."
msgstr "La tua query non può essere salvata"
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Italian translation</b></div>
<div id="fix">
The `msgstr` for the new message ID is empty, leaving users with Italian
locale seeing untranslated English text when this error occurs. Complete the
translation using the same phrasing pattern as other chart error messages in
this file.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/it/LC_MESSAGES/messages.po
+++ superset/translations/it/LC_MESSAGES/messages.po
@@ -3000,6 +3000,7 @@ msgstr "La tua query non pu\u00f2 essere salvata"
msgid "Chart could not be restored."
msgstr "La tua query non pu\u00f2 essere ripristinata"
+
msgid "Chart could not be updated."
msgstr "La tua query non pu\u00f2 essere salvata"
```
</div>
</details>
</div>
<small><i>Code Review Run #697b9f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/lv/LC_MESSAGES/messages.po:
##########
@@ -3072,6 +3072,9 @@ msgstr "Diagrammas izmaiņas"
msgid "Chart could not be created."
msgstr "Diagrammu nevarēja izveidot."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing source template update</b></div>
<div id="fix">
The source template `messages.pot` does not contain `msgid "Chart could not
be restored."`, but the English translation file does. This translation was
added directly without going through the standard i18n workflow. The source
template must be regenerated first (`pybabel extract` + `pybabel update`) to
ensure all language files receive this new string and the entry is properly
tracked.
</div>
</div>
<small><i>Code Review Run #1ed16d</i></small>
</div><div>
<div id="suggestion">
<div id="issue"><b>Missing translation for user-facing error</b></div>
<div id="fix">
The new translatable string "Chart could not be restored." (from
`ChartRestoreFailedError` in `superset/commands/chart/exceptions.py:133`) has
an empty `msgstr`. User-facing error messages should not be left untranslated.
Latvian follows the pattern "Diagrammu nevarēja [verb]." based on adjacent
entries.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/lv/LC_MESSAGES/messages.po
+++ superset/translations/lv/LC_MESSAGES/messages.po
@@ -3073,7 +3073,7 @@ msgstr "Diagrammu nevarēja izveidot."
msgid "Chart could not be restored."
-msgstr ""
+msgstr "Diagrammu nevarēja atjaunot."
msgid "Chart could not be updated."
```
</div>
</details>
</div>
<small><i>Code Review Run #697b9f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fa/LC_MESSAGES/messages.po:
##########
@@ -3065,6 +3065,9 @@ msgstr "تغییرات نمودار"
msgid "Chart could not be created."
msgstr "نمودار نتوانسته ایجاد شود."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Persian translation</b></div>
<div id="fix">
Empty `msgstr ""` at line 3069 will display as blank text to
Persian-speaking users when `ChartRestoreFailedError` is raised in
`superset/commands/chart/exceptions.py:133`. Other error messages in this file
(e.g., lines 3066, 3072) have complete Persian translations. Add the Persian
translation to avoid a degraded user experience.
</div>
</div>
<small><i>Code Review Run #697b9f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/pt/LC_MESSAGES/messages.po:
##########
@@ -3045,6 +3045,9 @@ msgstr "Modificado pela última vez"
msgid "Chart could not be created."
msgstr "Não foi possível gravar a sua query"
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Portuguese translation</b></div>
<div id="fix">
The Portuguese translation for "Chart could not be restored." is empty.
Portuguese-speaking users will see this error in English instead. Use a similar
phrasing to nearby translations (e.g., lines 3046, 3052) which use "Não foi
possível" for "could not".
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- a/superset/translations/pt/LC_MESSAGES/messages.po
+++ b/superset/translations/pt/LC_MESSAGES/messages.po
@@ -3046,7 +3046,7 @@ msgstr "Não foi possível gravar a sua query"
msgid "Chart could not be created."
msgstr "Não foi possível gravar a sua query"
msgid "Chart could not be restored."
-msgstr ""
+msgstr "Não foi possível restaurar o gráfico."
msgid "Chart could not be updated."
msgstr "Não foi possível gravar a sua query"
```
</div>
</details>
</div>
<small><i>Code Review Run #697b9f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/nl/LC_MESSAGES/messages.po:
##########
@@ -3118,6 +3118,9 @@ msgstr "Veranderingen in de grafiek"
msgid "Chart could not be created."
msgstr "Grafiek kon niet worden aangemaakt."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Dutch translation</b></div>
<div id="fix">
The new message "Chart could not be restored." is missing its Dutch
translation. Dutch users will see the untranslated English error message at
runtime. Following the established pattern in this file for similar error
messages (lines 3118-3119, 3124-3125), provide a Dutch translation using the
imperative form consistent with the existing translations.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/nl/LC_MESSAGES/messages.po (lines 3121-3122) ---
3121: +msgid "Chart could not be restored."
3122: +msgstr "De grafiek kon niet worden teruggezet."
```
</div>
</details>
</div>
<small><i>Code Review Run #697b9f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
