rusackas commented on PR #39240: URL: https://github.com/apache/superset/pull/39240#issuecomment-4773875291
@Aitema-gmbh the SkipLink side looks great and thanks for addressing my earlier notes. Two things before I approve: `prettier (frontend)` is red on `SkipLink.tsx` — a `pre-commit run prettier` should sort it. And `VisuallyHidden` isn't rendered anywhere — is it meant to land here, or should it split into its own PR alongside an actual consumer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
