bito-code-review[bot] commented on PR #41300:
URL: https://github.com/apache/superset/pull/41300#issuecomment-4774452712
<!-- Bito Reply -->
The suggestion to add type annotations to the new test function is correct,
as it improves code maintainability and adheres to the project's typing
standards. You can resolve this by updating the function signature in
`tests/unit_tests/config_swagger_ui_test.py` as follows:
```python
from typing import Any
@pytest.mark.parametrize(
"env_value, expected",
[
(None, False),
("true", True),
("True", True),
("false", False),
("", False),
],
)
def test_fab_api_swagger_ui_is_env_driven_and_off_by_default(
monkeypatch: pytest.MonkeyPatch, env_value: str | None, expected: bool
) -> None:
```
There are no other comments on this pull request to address. Would you like
me to assist with anything else?
**tests/unit_tests/config_swagger_ui_test.py**
```
from typing import Any
@pytest.mark.parametrize(
"env_value, expected",
[
(None, False),
("true", True),
("True", True),
("false", False),
("", False),
],
)
def test_fab_api_swagger_ui_is_env_driven_and_off_by_default(
monkeypatch: pytest.MonkeyPatch, env_value: str | None, expected: bool
) -> None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
