rusackas commented on code in PR #41300: URL: https://github.com/apache/superset/pull/41300#discussion_r3456956050
########## tests/unit_tests/config_swagger_ui_test.py: ########## @@ -0,0 +1,50 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Tests for environment-driven Swagger UI config defaults.""" + +import importlib + +import pytest + + [email protected]( + "env_value, expected", + [ + (None, False), # unset -> off by default + ("true", True), + ("True", True), + ("false", False), + ("", False), + ], +) +def test_fab_api_swagger_ui_is_env_driven_and_off_by_default( + monkeypatch, env_value, expected +): Review Comment: Added full type annotations to the test signature. ########## tests/unit_tests/config_swagger_ui_test.py: ########## @@ -0,0 +1,50 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Tests for environment-driven Swagger UI config defaults.""" + +import importlib + +import pytest + + [email protected]( + "env_value, expected", + [ + (None, False), # unset -> off by default + ("true", True), + ("True", True), + ("false", False), + ("", False), + ], +) +def test_fab_api_swagger_ui_is_env_driven_and_off_by_default( + monkeypatch, env_value, expected +): + if env_value is None: + monkeypatch.delenv("SUPERSET_ENABLE_SWAGGER_UI", raising=False) + else: + monkeypatch.setenv("SUPERSET_ENABLE_SWAGGER_UI", env_value) + + import superset.config as config + + importlib.reload(config) + try: + assert config.FAB_API_SWAGGER_UI is expected + finally: + # Restore the module to its environment-default state for other tests. + monkeypatch.delenv("SUPERSET_ENABLE_SWAGGER_UI", raising=False) + importlib.reload(config) Review Comment: Good catch — the teardown now reloads against the env value captured before the test instead of force-deleting it, so `config` no longer desyncs from what monkeypatch restores. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
