rusackas commented on code in PR #41300: URL: https://github.com/apache/superset/pull/41300#discussion_r3457604669
########## tests/unit_tests/config_swagger_ui_test.py: ########## @@ -0,0 +1,63 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Tests for environment-driven Swagger UI config defaults. + +``superset.config`` is imported in a fresh subprocess for each case so the +module is evaluated under a controlled environment without reloading (and +mutating) the config module shared by the rest of the test session. +""" + +import os +import subprocess +import sys + +import pytest + + +def _resolve_swagger_default(env_value: str | None) -> str: + env = dict(os.environ) + env.pop("SUPERSET_ENABLE_SWAGGER_UI", None) + if env_value is not None: + env["SUPERSET_ENABLE_SWAGGER_UI"] = env_value + result = subprocess.run( # noqa: S603 + [ + sys.executable, + "-c", + "import superset.config as c; print(c.FAB_API_SWAGGER_UI)", + ], + env=env, + capture_output=True, + text=True, + check=True, + ) + return result.stdout.strip() Review Comment: Added a docstring to the helper. ########## tests/unit_tests/config_swagger_ui_test.py: ########## @@ -0,0 +1,63 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Tests for environment-driven Swagger UI config defaults. + +``superset.config`` is imported in a fresh subprocess for each case so the +module is evaluated under a controlled environment without reloading (and +mutating) the config module shared by the rest of the test session. +""" + +import os +import subprocess +import sys + +import pytest + + +def _resolve_swagger_default(env_value: str | None) -> str: + env = dict(os.environ) + env.pop("SUPERSET_ENABLE_SWAGGER_UI", None) + if env_value is not None: + env["SUPERSET_ENABLE_SWAGGER_UI"] = env_value + result = subprocess.run( # noqa: S603 + [ + sys.executable, + "-c", + "import superset.config as c; print(c.FAB_API_SWAGGER_UI)", + ], + env=env, + capture_output=True, + text=True, + check=True, + ) + return result.stdout.strip() + + [email protected]( + "env_value, expected", + [ + (None, "False"), # unset -> off by default + ("true", "True"), + ("True", "True"), + ("false", "False"), + ("", "False"), + ], +) +def test_fab_api_swagger_ui_is_env_driven_and_off_by_default( + env_value: str | None, expected: str +) -> None: + assert _resolve_swagger_default(env_value) == expected Review Comment: Added a docstring to the test. ########## tests/unit_tests/config_swagger_ui_test.py: ########## @@ -0,0 +1,63 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Tests for environment-driven Swagger UI config defaults. + +``superset.config`` is imported in a fresh subprocess for each case so the +module is evaluated under a controlled environment without reloading (and +mutating) the config module shared by the rest of the test session. +""" + +import os +import subprocess +import sys + +import pytest + + +def _resolve_swagger_default(env_value: str | None) -> str: + env = dict(os.environ) + env.pop("SUPERSET_ENABLE_SWAGGER_UI", None) + if env_value is not None: + env["SUPERSET_ENABLE_SWAGGER_UI"] = env_value Review Comment: Good point — the subprocess now drops `SUPERSET_CONFIG_PATH`/`SUPERSET_CONFIG` and reads only the last stdout line, so a local config can no longer taint the default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
