rusackas commented on PR #41024: URL: https://github.com/apache/superset/pull/41024#issuecomment-4775341214
Thanks @innovark37! Circled back because the codeant bot flagged a couple things, and it was actually right on both this time. When the requested page sits past the configured row limit, `remainingRows` hits 0 and `row_limit` collapses to 0, which the backend reads as "no limit" (`if row_limit:` in `helpers.py`), so it'd quietly return the whole table instead of capping. And the filter-reset block was persisting that capped per-request limit into `pageSize`, so changing a filter on the last page silently shrank the page size. I pushed a fix to clamp the page to the last one inside the limit and persist the user-selected page size instead, plus a test for the row_limit:0 case. Left the rest of your logic intact. Should be good once CI's green, but holler if you'd rather take a different tack on the clamp. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
