rusackas commented on PR #41024: URL: https://github.com/apache/superset/pull/41024#issuecomment-4781726609
I think the CodeAnt logic comments here are already handled by your last couple commits (the `lastPage` clamp and recomputing `firstPageRowLimit` on reset). The bot also flagged the `buildQuery` duplication with `plugin-chart-ag-grid-table`, which turns out to have the exact same row-limit bug, so I ported your fix over there in #41346. LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
