rusackas commented on PR #41024: URL: https://github.com/apache/superset/pull/41024#issuecomment-4775494960
Yeah, the bot caught a third real one, same root cause: on a filter reset we zeroed the offset but kept the last page's capped `row_limit`, so the first page after a filter change came back short. Fixed it to restore the full first-page limit. Rather than keep whacking these one at a time, I exported `buildQuery` and added tests across the whole matrix, user limit under the page size, capped last page, paging past the limit (no more row_limit:0), the first-page restore plus page-size persistence on reset, and the no-row-limit fallback. That should have the row-limit/pagination interactions pinned down now. Green locally, holler if you spot a case I missed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
