Re: [PR] feat(mcp): add duplicate_dashboard tool [superset]

via GitHub Mon, 29 Jun 2026 10:26:26 -0700


codeant-ai-for-open-source[bot] commented on code in PR #40959:
URL: https://github.com/apache/superset/pull/40959#discussion_r3493547947



##########
superset/mcp_service/dashboard/schemas.py:
##########
@@ -914,6 +914,138 @@ class GenerateDashboardResponse(BaseModel):
     )
 
 
+class DuplicateDashboardRequest(BaseModel):
+    """Request schema for duplicating an existing dashboard."""
+
+    model_config = ConfigDict(populate_by_name=True)
+
+    dashboard_id: Annotated[
+        int | str,
+        Field(
+            description=(
+                "Source dashboard identifier - can be numeric ID, UUID string, 
or slug"
+            )
+        ),
+    ]

Review Comment:
   **Suggestion:** For this new API request schema, remove support for integer 
identifiers and accept only UUID-based string identifiers (optionally slug) so 
the interface does not expose auto-increment primary-key IDs. [custom_rule]
   
   **Severity Level:** Minor ⚠️
   <details>
   <summary><b>Why it matters? 🤔 </b></summary>
   
   This new request schema explicitly accepts a numeric dashboard ID, which 
exposes an auto-incrementing primary-key style identifier in a public API 
surface. That matches the UUID-primary-key rule’s intent to avoid integer IDs 
for new public-facing APIs, so the suggestion is verified.
   </details>
   
   [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=81f3d22d51964f7ea33b1cf3af20d08d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=81f3d22d51964f7ea33b1cf3af20d08d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/mcp_service/dashboard/schemas.py
   **Line:** 922:929
   **Comment:**
        *Custom Rule: For this new API request schema, remove support for 
integer identifiers and accept only UUID-based string identifiers (optionally 
slug) so the interface does not expose auto-increment primary-key IDs.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40959&comment_hash=2b8caa1c5f0764151b39641ebc52e06e56e732e7ad8c4768c90d64d389efcdf8&reaction=like'>👍</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40959&comment_hash=2b8caa1c5f0764151b39641ebc52e06e56e732e7ad8c4768c90d64d389efcdf8&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] feat(mcp): add duplicate_dashboard tool [superset]

Reply via email to