rusackas commented on PR #40959: URL: https://github.com/apache/superset/pull/40959#issuecomment-4835724992
These two guards (empty/stale layout) don't exist on the REST /copy/ endpoint, which would just produce the copy. Dashboards created via API or import can legitimately carry slices without position_json entries; for those this tool now hard-fails where "Save as" would succeed. I'm fine with the fail-fast, but please call out this intentional divergence in the docstring/PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
