aminghadersohi commented on PR #40960: URL: https://github.com/apache/superset/pull/40960#issuecomment-4835310323
Addressing bito review findings from runs #13a2f1 and #51f943 (commit 582ebf891c): **Dead type cast (run #51f943):** Fixed — removed the runtime-noop `cast(list[dict[str, Any]], ...)` wrapper around `sanitize_for_llm_context()` in `_filter_summary` and dropped the now-unused `cast` import. **Missing reorder duplicate test (run #51f943):** Fixed — added `test_reorder_duplicate_filter_ids_rejected` covering the `len(set(request.reorder)) != len(request.reorder)` guard in `_build_native_filters_payload`. **Incomplete test stub (run #51f943, `test_update_unknown_filter_id`):** This test is already fully implemented — it patches the DAO, calls `_call`, and asserts on the error response. Bito flagged it in an earlier draft before the body was committed; the current HEAD is not empty. **Dead exception handler (run #13a2f1, `except DashboardNotFoundError`):** Not dead. `UpdateDashboardNativeFiltersCommand.run()` calls `super().validate()` which calls `DashboardDAO.find_by_id()` and raises `DashboardNotFoundError()` if it returns `None`. This is a race-condition guard (dashboard deleted between the initial check and the command execution). Keeping it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
