aminghadersohi commented on PR #40960: URL: https://github.com/apache/superset/pull/40960#issuecomment-4835480146
Fixed pre-commit CI failures in 49c78fbbda: - **ruff-format** (test file): removed unnecessary parentheses around single-string assignment — auto-fixed by ruff format. - **ruff C901** (`update_native_filters_config` complexity 11 > 10): The previous commit added a `try/except` guard that pushed McCabe complexity from 10 to 11. Simplified the modify/delete loop by pre-building a `deleted_ids` set and `modified_map` dict, replacing two generator-expression `if` branches and an explicit `if modified_filter` conditional with a single `modified_map.get(conf_id, conf)` call. Complexity now 8. No behaviour change — all 22 unit tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
