rusackas commented on PR #40960: URL: https://github.com/apache/superset/pull/40960#issuecomment-4835735788
Also, the current_config snapshot read here (T1) and the re-read inside UpdateDashboardNativeFiltersCommand (T2) aren't covered by a shared lock or a version check on json_metadata. If another writer commits in between, a concurrently added filter gets silently dropped when this request also does a reorder (its id is in neither reordered nor modified, so the DAO's rebuild discards it). This mirrors existing REST behavior, but since this tool may be driven by an agent issuing frequent reorders, worth at least a docstring note — ideally re-read inside the command's transaction and reject if changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
