dmunozv04 commented on PR #40507: URL: https://github.com/apache/superset/pull/40507#issuecomment-4845282193
Hi @aminghadersohi, thanks for the review. I didn't add an ingress gate for mcp since it also wasn't done for the web sockets deployment. The [existing docs](https://superset.apache.org/admin-docs/configuration/mcp-server#authentication) already warn the user to setup proper authentication for the MCP server and AFAICT the mcp server will refuse to allow any requests if an authentication source is not configured [`superset/mcp_service/auth.py:L610`](https://github.com/apache/superset/blob/b536933245f66fb0b548671be6089c9eea22c6e3/superset/mcp_service/auth.py#L610). Let me know if you want me to gate the ingress with a `supersetMcp.ingress.enabled` flag I totally missed the copy-paste on the `deploymentAdditionalPodSpec`, thanks for catching that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
