dmunozv04 commented on code in PR #40507: URL: https://github.com/apache/superset/pull/40507#discussion_r3521143603
########## helm/superset/values.yaml: ########## @@ -807,6 +807,143 @@ supersetWebsockets: # -- Set priorityClassName for supersetWebsockets pods priorityClassName: ~ + +supersetMcp: + # -- Enables the Superset MCP Server, exposed by default via the ingress /mcp subpath + # WARNING: this requires fastMCP to be installed, which can be done by installing `apache-superset[fastmcp]` + enabled: false + replicaCount: 1 + # -- Sets the [pod disruption budget](https://kubernetes.io/docs/tasks/run-application/configure-pdb/) for supersetMcp pods + podDisruptionBudget: + # -- Whether the pod disruption budget should be created + enabled: false + # -- If set, maxUnavailable must not be set - see https://kubernetes.io/docs/tasks/run-application/configure-pdb/\#specifying-a-poddisruptionbudget + minAvailable: 1 + # -- If set, minAvailable must not be set - see https://kubernetes.io/docs/tasks/run-application/configure-pdb/\#specifying-a-poddisruptionbudget + maxUnavailable: 1 + # -- Command + # @default -- a `superset mcp run` command + command: + - "/bin/sh" + - "-c" + - ". {{ .Values.configMountPath }}/superset_bootstrap.sh; superset mcp run --host 0.0.0.0 --port 5008" + # -- If true, forces deployment to reload on each upgrade + forceReload: false + ingress: + path: /mcp + pathType: Prefix + service: + type: ClusterIP + annotations: {} + loadBalancerIP: ~ + port: 5008 + nodePort: + # -- (int) + http: nil + startupProbe: + httpGet: + path: /mcp + port: 5008 + httpHeaders: + - name: Accept + value: text/html + initialDelaySeconds: 15 + timeoutSeconds: 3 + failureThreshold: 60 + periodSeconds: 5 + successThreshold: 1 + livenessProbe: + httpGet: + path: /mcp + port: 5008 + httpHeaders: + - name: Accept + value: text/html + initialDelaySeconds: 15 + timeoutSeconds: 3 + failureThreshold: 3 + periodSeconds: 15 + successThreshold: 1 + readinessProbe: + httpGet: + path: /mcp + port: 5008 + httpHeaders: + - name: Accept + value: text/html + initialDelaySeconds: 15 + timeoutSeconds: 3 + failureThreshold: 3 + periodSeconds: 15 + successThreshold: 1 + # -- List of init containers + # @default -- a container waiting for postgres and redis + initContainers: + - name: wait-for-postgres-redis + image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" + imagePullPolicy: "{{ .Values.image.pullPolicy }}" + envFrom: + - secretRef: + name: "{{ tpl .Values.envFromSecret . }}" + command: + - /bin/bash + - -c + - | + # See supersetNode.initContainers for the rationale. + SECONDS=0 + wait_for() { + local host=$1 port=$2 name=$3 + until (exec 3<>/dev/tcp/"$host"/"$port") 2>/dev/null; do + if [ "$SECONDS" -ge 120 ]; then + echo "timeout waiting for $name at $host:$port after 120s" >&2 + exit 1 + fi + echo "waiting for $name at $host:$port (elapsed ${SECONDS}s)" + sleep 2 + done + echo "$name at $host:$port is up" + } + wait_for "$DB_HOST" "$DB_PORT" postgres + wait_for "$REDIS_HOST" "$REDIS_PORT" redis + resources: + limits: + memory: "256Mi" + requests: + cpu: "250m" + memory: "128Mi" + # -- Launch additional containers into supersetMcp pods + extraContainers: [] + # -- Annotations to be added to supersetMcp deployment + deploymentAnnotations: {} + # -- Labels to be added to supersetMcp deployment + deploymentLabels: {} + # -- Custom pod spec to be added to supersetMcp deployment + deploymentAdditionalPodSpec: {} + # -- Affinity to be added to supersetMcp deployment + affinity: {} + # -- TopologySpreadConstrains to be added to supersetMcp deployments + topologySpreadConstraints: [] + # -- Annotations to be added to supersetMcp pods + podAnnotations: {} + # -- Labels to be added to supersetMcp pods + podLabels: {} + # -- Container lifecycle hooks for the worker pod + lifecycle: {} + # -- Pod termination grace period (seconds) for the worker pod so in-flight tasks can drain before SIGKILL + terminationGracePeriodSeconds: ~ + # -- Resource settings for the supersetMcp pods - these settings overwrite might existing values from the global resources object defined above. + resources: {} + # limits: + # cpu: 100m + # memory: 128Mi + # requests: + # cpu: 100m + # memory: 128Mi + podSecurityContext: {} + containerSecurityContext: {} + # -- Set priorityClassName for supersetMcp pods + priorityClassName: ~ Review Comment: Added missing `strategy` block on `values.yaml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
