aminghadersohi commented on code in PR #40507: URL: https://github.com/apache/superset/pull/40507#discussion_r3521238805
########## helm/superset/values.yaml: ########## @@ -807,6 +807,150 @@ supersetWebsockets: # -- Set priorityClassName for supersetWebsockets pods priorityClassName: ~ + +supersetMcp: + # -- Enables the Superset MCP Server, exposed by default via the ingress /mcp subpath Review Comment: **NIT** — This comment says "exposed _by default_ via the ingress `/mcp` subpath", but with the new `supersetMcp.ingress.enabled` flag (default `false`), the MCP server is not ingress-exposed by default — operators must explicitly set `supersetMcp.ingress.enabled: true`. Suggest updating to avoid misleading future operators, e.g.: ```yaml # -- Enables the Superset MCP Server. To expose it via the shared ingress at /mcp, also set supersetMcp.ingress.enabled=true. # WARNING: this requires fastMCP to be installed via `apache-superset[fastmcp]` ``` `helm-docs` will pick up the corrected description into `README.md` automatically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
