rusackas commented on PR #40130: URL: https://github.com/apache/superset/pull/40130#issuecomment-4861086526
1. There are still a TON of bot comments that haven't been resolved (also, there are SO many commits... maybe squashing this will make it more possible to read the gigantic github thread, which you currently have to expand a whole bunch of times to even see everything) 2. I think you'll want to rebase onto post-#41166 master so CI runs against the gated path? 3. Two validation changes ship even with SOFT_DELETE offL catalog-NULL-aware uniqueness matching, and duplicate.py's scope change. Please confirm they're meant to be un-gated. 4. Any DB that has ever had datasets can't be deleted via API once they're soft-deleted (no purge in v1). Sounds like that's intended but just triple checking. 5. _escape_like change might be unrelated scope creep? Not a blocker, just noting it in case it's worth splitting out or whatever. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
