bito-code-review[bot] commented on code in PR #41749:
URL: https://github.com/apache/superset/pull/41749#discussion_r3521332310
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts:
##########
@@ -365,9 +317,8 @@ export function getLegendLayoutResult({
theme,
type,
}: {
- // Raw chart dimensions. Use availableWidth/availableHeight when other chart
- // UI elements reserve legend space before ECharts lays out the legend.
- availableHeight?: number;
+ // Raw chart dimensions. Use availableWidth when other chart UI elements
+ // reserve legend space before ECharts lays out the legend.
availableWidth?: number;
chartHeight: number;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Unused parameter creates dead code</b></div>
<div id="fix">
The `chartHeight` parameter is destructured (line 309) but never referenced
in the function body. Keeping an unused parameter in the type definition
creates misleading API documentation and suggests callers should provide a
value that's ignored. Remove `chartHeight: number;` from line 323 alongside the
destructuring removal.
</div>
</div>
<small><i>Code Review Run #8b737a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
