rusackas commented on PR #41749: URL: https://github.com/apache/superset/pull/41749#issuecomment-4910067611
Thanks @jesperct. Honoring an explicit List choice instead of flipping to scroll makes sense, and the common wide-chart case looks fine. The thing I'd want to sort before merging is the unbounded margin the bot flagged... on a narrow, tall chart with a lot of series, `requiredMargin` can grow past the chart height and push `grid.top` off-canvas, collapsing the plot to nothing. That's arguably worse than the auto-scroll it's replacing. Any appetite for clamping the reserved rows to some sane max, so a huge legend can't eat the whole plot? Happy to keep List honored, just bounded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
