codeant-ai-for-open-source[bot] commented on code in PR #41749:
URL: https://github.com/apache/superset/pull/41749#discussion_r3530426522
##########
superset-frontend/plugins/plugin-chart-echarts/test/Gantt/transformProps.test.ts:
##########
@@ -344,7 +344,7 @@ describe('legend sorting', () => {
const result = transformProps(props as EchartsGanttChartProps);
- expect((result.echartOptions.legend as any).type).toBe(LegendType.Scroll);
+ expect((result.echartOptions.legend as any).type).toBe(LegendType.Plain);
Review Comment:
**Suggestion:** Replace the `any` cast with a concrete legend option type
(or a narrowed type assertion) before reading `type`. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The new TypeScript test code explicitly casts `result.echartOptions.legend`
to `any` before accessing `type`, which matches the custom rule prohibiting
`any` in changed TypeScript code. A concrete legend option type or narrower
assertion should be used instead.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=49df1051bbd74662af5a8e53115ad0ad&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=49df1051bbd74662af5a8e53115ad0ad&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/test/Gantt/transformProps.test.ts
**Line:** 347:347
**Comment:**
*Custom Rule: Replace the `any` cast with a concrete legend option type
(or a narrowed type assertion) before reading `type`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41749&comment_hash=b34496fa757dd2e23634f446aed82c8a10271a2240a5c5f9439232eb156fb2de&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41749&comment_hash=b34496fa757dd2e23634f446aed82c8a10271a2240a5c5f9439232eb156fb2de&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
