villebro commented on a change in pull request #8409: [ci] Deprecate flake8
URL:
https://github.com/apache/incubator-superset/pull/8409#discussion_r336322469
##########
File path: superset/views/annotations.py
##########
@@ -43,7 +43,7 @@ def __call__(self, form, field):
)
-class AnnotationModelView(SupersetModelView, DeleteMixin): # noqa
+class AnnotationModelView(SupersetModelView, DeleteMixin):
Review comment:
Out of scope, but shouldn't mixins in general be before the base class?
Seems like an antipattern to expect the base class to have functionality that
overrides the mixin..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
