villebro commented on a change in pull request #8409: [ci] Deprecate flake8
URL:
https://github.com/apache/incubator-superset/pull/8409#discussion_r336320014
##########
File path: superset/__init__.py
##########
@@ -103,7 +104,7 @@ def get_manifest():
#################################################################
-for bp in conf.get("BLUEPRINTS"):
+for bp in conf["BLUEPRINTS"]:
Review comment:
These types of conventions, e.g. parameters defined in `config.py` are
assumed to always be defined, should probably be documented in the developer
guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
