villebro commented on a change in pull request #8409: [ci] Deprecate flake8
URL:
https://github.com/apache/incubator-superset/pull/8409#discussion_r336321064
##########
File path: superset/connectors/druid/models.py
##########
@@ -137,14 +134,14 @@ class DruidCluster(Model, AuditMixinNullable,
ImportMixin):
broker_user = Column(String(255))
broker_pass = Column(EncryptedType(String(255), conf.get("SECRET_KEY")))
- export_fields = (
+ export_fields = [
"cluster_name",
"broker_host",
"broker_port",
"broker_endpoint",
"cache_timeout",
"broker_user",
- )
+ ]
Review comment:
Is there some specific reason why these are made mutable? This is mostly out
of scope for this PR, but I think in general it might be a good idea to have
functions/methods expect `Sequence` instead of `List`/`Tuple` when the idea is
just to iterate and read over the sequence of values and then leave it up to
the caller to decide on whether or not to send across a `Tuple` or `List.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
