bito-code-review[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3536772477
##########
superset-frontend/src/visualizations/TimeTable/TimeTable.test.tsx:
##########
@@ -91,7 +91,7 @@ test('should render table headers', () => {
);
const visibleTimeSeriesHeaders = allTimeSeriesHeaders.filter(
- el => !el.closest('.ant-table-measure-cell-content'),
+ el => !el.closest('.ant-table-measure-row'),
Review Comment:
<!-- Bito Reply -->
The suggestion provided by the reviewer is appropriate and improves
consistency within the test file. Applying this change ensures that the
filtering logic uses the correct selector, matching the pattern established
elsewhere in the codebase.
**superset-frontend/src/visualizations/TimeTable/TimeTable.test.tsx**
```
const visibleTimeSeriesHeaders = allTimeSeriesHeaders.filter(
- el => !el.closest('.ant-table-measure-cell-content'),
+ el => !el.closest('.ant-table-measure-row'),
```
##########
superset-frontend/src/components/TableSelector/TableSelector.test.tsx:
##########
@@ -60,7 +60,7 @@ const tablesApiRoute = 'glob:*/api/v1/database/*/tables/*';
const getSelectItemContainer = (select: HTMLElement) =>
select.parentElement?.parentElement?.getElementsByClassName(
- 'ant-select-selection-item',
+ 'ant-select-content-has-value',
Review Comment:
<!-- Bito Reply -->
The suggestion is appropriate and improves the code by ensuring the selector
is compatible with both single- and multi-select Ant Design components.
Applying this change correctly addresses the regression by checking for both
class names.
**superset-frontend/src/components/TableSelector/TableSelector.test.tsx**
```
const getSelectItemContainer = (select: HTMLElement) =>
select.parentElement?.parentElement?.querySelectorAll(
'.ant-select-content-has-value, .ant-select-selection-item',
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
