rusackas commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3536771329
##########
superset-frontend/src/visualizations/TimeTable/TimeTable.test.tsx:
##########
@@ -91,7 +91,7 @@ test('should render table headers', () => {
);
const visibleTimeSeriesHeaders = allTimeSeriesHeaders.filter(
- el => !el.closest('.ant-table-measure-cell-content'),
+ el => !el.closest('.ant-table-measure-row'),
Review Comment:
Good catch, fixed — line 179 had the same `.ant-table-measure-cell-content`
selector, updated it to `.ant-table-measure-row` to match line 94.
##########
superset-frontend/src/components/TableSelector/TableSelector.test.tsx:
##########
@@ -60,7 +60,7 @@ const tablesApiRoute = 'glob:*/api/v1/database/*/tables/*';
const getSelectItemContainer = (select: HTMLElement) =>
select.parentElement?.parentElement?.getElementsByClassName(
- 'ant-select-selection-item',
+ 'ant-select-content-has-value',
Review Comment:
Fixed — `getSelectItemContainer` now checks both
`.ant-select-content-has-value` and `.ant-select-selection-item` so it works
for single- and multi-select.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
