bito-code-review[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3535313797
##########
superset-frontend/src/visualizations/TimeTable/TimeTable.test.tsx:
##########
@@ -91,7 +91,7 @@ test('should render table headers', () => {
);
const visibleTimeSeriesHeaders = allTimeSeriesHeaders.filter(
- el => !el.closest('.ant-table-measure-cell-content'),
+ el => !el.closest('.ant-table-measure-row'),
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete selector update in same file</b></div>
<div id="fix">
This change aligns line 94 with the pattern used elsewhere in the codebase
(QueryTable.test.tsx, ChartList.listview.test.tsx). However, line 179 in the
same file has an identical filter that still uses the old selector
`.ant-table-measure-cell-content`, creating intra-file inconsistency for the
same filtering logic.
</div>
</div>
<small><i>Code Review Run #f47c11</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset-frontend/src/components/TableSelector/TableSelector.test.tsx:
##########
@@ -60,7 +60,7 @@ const tablesApiRoute = 'glob:*/api/v1/database/*/tables/*';
const getSelectItemContainer = (select: HTMLElement) =>
select.parentElement?.parentElement?.getElementsByClassName(
- 'ant-select-selection-item',
+ 'ant-select-content-has-value',
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Ant Design class selector regression</b></div>
<div id="fix">
Please update the selector in `getSelectItemContainer` to support both Ant
Design class names. For example, use
`parentElement?.parentElement?.querySelectorAll('.ant-select-content-has-value,
.ant-select-selection-item')` or `getElementsByClassName` with both class names
to maintain compatibility across versions.
</div>
</div>
<small><i>Code Review Run #f47c11</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
