bito-code-review[bot] commented on code in PR #26230:
URL: https://github.com/apache/superset/pull/26230#discussion_r3540415892
##########
superset-frontend/plugins/legacy-plugin-chart-calendar/src/controlPanel.ts:
##########
@@ -136,6 +136,32 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'color_range_start',
+ config: {
+ type: 'TextControl',
+ isInt: true,
+ validators: [legacyValidateInteger],
+ renderTrigger: true,
+ default: undefined,
+ label: t('Color Range Start'),
+ description: t('test'),
Review Comment:
<!-- Bito Reply -->
The update to the control descriptions is appropriate. Providing specific
guidance on the purpose of these controls, such as their role in custom color
scaling, improves the clarity and usability of the configuration panel compared
to the previous placeholder text.
**superset-frontend/plugins/legacy-plugin-chart-calendar/src/controlPanel.ts**
```
config: {
type: 'TextControl',
isInt: true,
validators: [legacyValidateInteger],
renderTrigger: true,
default: undefined,
label: t('Color Range Start'),
description: t('test'),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
