codeant-ai-for-open-source[bot] commented on code in PR #26230:
URL: https://github.com/apache/superset/pull/26230#discussion_r3540557621
##########
superset-frontend/plugins/legacy-plugin-chart-calendar/src/controlPanel.ts:
##########
@@ -136,6 +136,40 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'color_range_start',
+ config: {
+ type: 'TextControl',
+ isInt: true,
+ validators: [legacyValidateInteger],
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Keep the calendar chart color range controls integer-only unless their
parsing/validation is updated to handle raw string float inputs safely;
`TextControl` currently preserves values like `1.` or `1.0` as strings, which
can bypass `Number.isFinite` and disable the custom range.
**Applied to:**
-
`superset-frontend/plugins/legacy-plugin-chart-calendar/src/controlPanel.ts`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
