rusackas commented on PR #26230: URL: https://github.com/apache/superset/pull/26230#issuecomment-4910181012
@michael-s-molina pushed fixes for your notes here, real descriptions on the two controls and `Number.isFinite` for the range validation. Also took the bot's off-by-one catch (`colorRangeEnd - 1` → the exact value), which was what had `lint-frontend`/`validate-frontend` red. SIP-113 passed back in Oct '24, so the procedural hold should be clear now... mind releasing the changes-requested if the fixes look good? Running CI 🤞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
