bito-code-review[bot] commented on PR #41870:
URL: https://github.com/apache/superset/pull/41870#issuecomment-4910250834
<!-- Bito Reply -->
The suggestion to add explicit type hints to the new test method
`test_jinja_calculated_column_in_order_by` is correct and aligns with standard
Python development practices for maintaining codebase quality. To resolve this,
you should update the method signature to include a return type annotation,
typically `-> None` for test methods.
Here is the corrected method signature:
```python
@mock.patch("superset.models.core.Database.db_engine_spec",
BaseEngineSpec)
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_jinja_calculated_column_in_order_by(self) -> None:
"""
A calculated column referenced by a SIMPLE adhoc metric in `orderby`
should have its Jinja template rendered, the same way it is for
SELECT/WHERE/GROUP BY.
"""
```
There are no other review comments on this pull request to address. Would
you like me to assist with anything else?
**tests/integration_tests/db_engine_specs/base_engine_spec_tests.py**
```
@mock.patch("superset.models.core.Database.db_engine_spec", BaseEngineSpec)
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_jinja_calculated_column_in_order_by(self) -> None:
"""
A calculated column referenced by a SIMPLE adhoc metric in `orderby`
should have its Jinja template rendered, the same way it is for
SELECT/WHERE/GROUP BY.
"""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
