codeant-ai-for-open-source[bot] commented on code in PR #41870:
URL: https://github.com/apache/superset/pull/41870#discussion_r3540462492
##########
tests/integration_tests/db_engine_specs/base_engine_spec_tests.py:
##########
@@ -202,6 +202,51 @@ def
test_calculated_column_in_order_by_base_engine_spec(self):
in sql
)
+ @mock.patch("superset.models.core.Database.db_engine_spec", BaseEngineSpec)
+ @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
+ def test_jinja_calculated_column_in_order_by(self):
Review Comment:
**Suggestion:** Add explicit type hints to the new test method signature,
including a return annotation, to satisfy the repository typing requirement for
modified Python functions. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The new test method is a modified Python function and its signature has no
type hints or return annotation. This matches the repository rule requiring
type hints on new or modified Python code where annotations can be added.
</details>
<details>
<summary><b>Rule source 📖 </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9fa18b55a1e246e2a60cfc8006806e42&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9fa18b55a1e246e2a60cfc8006806e42&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/db_engine_specs/base_engine_spec_tests.py
**Line:** 207:207
**Comment:**
*Custom Rule: Add explicit type hints to the new test method signature,
including a return annotation, to satisfy the repository typing requirement for
modified Python functions.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41870&comment_hash=279fa6fdfe4a0b5c65bc71953b292e8163b29a0e7eb174353287b63684e331c1&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41870&comment_hash=279fa6fdfe4a0b5c65bc71953b292e8163b29a0e7eb174353287b63684e331c1&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
