rusackas commented on code in PR #41870:
URL: https://github.com/apache/superset/pull/41870#discussion_r3540748020
##########
tests/integration_tests/db_engine_specs/base_engine_spec_tests.py:
##########
@@ -202,6 +202,51 @@ def
test_calculated_column_in_order_by_base_engine_spec(self):
in sql
)
+ @mock.patch("superset.models.core.Database.db_engine_spec", BaseEngineSpec)
+ @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
+ def test_jinja_calculated_column_in_order_by(self):
Review Comment:
Added the `-> None` return annotation. That also made mypy actually check
the body (previously skipped for untyped defs), which surfaced a real
`query_obj` typing gap — fixed with a `cast(QueryObjectDict, ...)` like the
rest of the test suite uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
