rusackas commented on code in PR #41871:
URL: https://github.com/apache/superset/pull/41871#discussion_r3540737418


##########
superset-frontend/src/dashboard/components/filterscope/FilterScopeSelector.tsx:
##########
@@ -313,7 +313,7 @@ const ScopeSelector = styled.div`
           display: block;
         }
 
-        // disable style from react-checkbox-trees.css
+        /* disable style from react-checkbox-trees.css */

Review Comment:
   Good catch, fixed — was `react-checkbox-trees.css`, should be 
`react-checkbox-tree.css`.



##########
.rat-excludes:
##########
@@ -7,6 +7,8 @@
 .codecov.yml
 .eslintrc
 .eslintignore
+.stylelintrc.json
+.stylelintignore

Review Comment:
   These match by filename, not full path — same as the 
`.eslintrc`/`.eslintignore` entries right above them (which also live in 
`superset-frontend/`, not root). The header comment in `.rat-excludes` calls 
this out explicitly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to