rusackas commented on code in PR #41871:
URL: https://github.com/apache/superset/pull/41871#discussion_r3552405863
##########
superset-frontend/package.json:
##########
@@ -358,6 +361,7 @@
"speed-measure-webpack-plugin": "^1.6.0",
"storybook": "10.4.6",
"style-loader": "^4.0.0",
+ "stylelint": "^16.26.1",
Review Comment:
Fair, bumped to 17.14.0. Backward compatible with the hidden
`.stylelintrc.json` we already have, and the full glob still runs clean.
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -138,7 +138,6 @@ const ResultlessStyles = styled.div`
// but wrapping text too so text doesn't overflow
const MonospaceDiv = styled.div`
font-family: ${({ theme }) => theme.fontFamilyCode};
- white-space: pre;
Review Comment:
Intentional, it's a duplicate. was declared after in the same rule, so it
was already winning, the line was just dead weight caught.
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -138,7 +138,6 @@ const ResultlessStyles = styled.div`
// but wrapping text too so text doesn't overflow
const MonospaceDiv = styled.div`
font-family: ${({ theme }) => theme.fontFamilyCode};
- white-space: pre;
Review Comment:
Intentional, it's a duplicate. `pre-wrap` was declared after `pre` in the
same rule, so it was already winning; the `pre` line was just dead weight the
duplicate-properties rule caught.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
