hainenber commented on code in PR #41871:
URL: https://github.com/apache/superset/pull/41871#discussion_r3544938388
##########
superset-frontend/package.json:
##########
@@ -358,6 +361,7 @@
"speed-measure-webpack-plugin": "^1.6.0",
"storybook": "10.4.6",
"style-loader": "^4.0.0",
+ "stylelint": "^16.26.1",
Review Comment:
currently, s[tylelint v17 is the
latest](https://github.com/stylelint/stylelint/releases/tag/17.14.0). Let's
strive for currency :D
##########
superset-frontend/.stylelintrc.json:
##########
@@ -0,0 +1,16 @@
+{
Review Comment:
IMO, let's have the config to be non-hidden for better discoverability and
in fact, since v17, non-hidden config file to be the go-to approach.
##########
superset-frontend/src/features/home/SavedQueries.tsx:
##########
@@ -88,7 +88,6 @@ export const CardStyles = styled.div`
display: inline-block;
width: 100%;
height: 179px;
- background-repeat: no-repeat;
Review Comment:
Ditto on whether this is intentional
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -138,7 +138,6 @@ const ResultlessStyles = styled.div`
// but wrapping text too so text doesn't overflow
const MonospaceDiv = styled.div`
font-family: ${({ theme }) => theme.fontFamilyCode};
- white-space: pre;
Review Comment:
Is the deletion here intentional? `white-space: pre` is a valid combo, iirc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
