GitHub user hy144328 added a comment to the discussion: Roadmap to SQLAlchemy 2
Sorry for the inactivity. Let me get started again, and crush some of the lower-hanging items from the checklist tonight and tomorrow. I.e., those items that are mainly local syntax changes. I have some me time this weekend that I would like to use to look at the refactor of the ORM models. https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#migration-to-2-0-step-six-add-allow-unmapped-to-explicitly-typed-orm-models I am tempted to take the 'quick and dirty' path of just adding `__allow_unmapped__` to the declarative `Base` for now. This would allow us to postpone the full refactor of the ORM models until after the version bump. The version bump of SQLAlchemy and the associated Flask dependencies carries arguably the highest risk in this whole endeavor. So the upside of this quick and dirty path is that we get to focus more on the critical step. The downside is that the type system is weakened because annotations are by-passed. Let me know if this temporary state is unacceptable. If things go well, by the beginning of next week, let us bump the SQLAlchemy version. I will need you or someone else to release the PR for integration tests. I will probably need some additional help for testing because I do not know how complete the coverage of the integration tests is. Let me know what you think. Again, let me also try to get a few PRs up tonight to get the ball rolling again. GitHub link: https://github.com/apache/superset/discussions/40273#discussioncomment-17589750 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
